Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

different attention map for each element of feature dimension #3

Merged
merged 1 commit into from
Jan 18, 2021

Conversation

lucidrains
Copy link
Owner

No description provided.

@@ -47,8 +47,8 @@ def forward(self, x, pos):
v = v + rel_pos_emb

# attention
attn = sim.softmax(dim = -1)
attn = sim.softmax(dim = -2)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot confirm which axis that the softmax conduct on.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm pretty confident this is the right axis j - sim is (batch x query rows x query-key similarities per row x feature dimension)

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm just not sure if the attention MLP does not reduce to one attention map that aggregates across all feature value vectors. if someone else can confirm this is indeed the case, i'll merge and release the corrected version

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, the point transformer in paper is used to informtion exchange or interaction, other than aggregation. The maxpooing in Pointnet++ is assigned to feature aggregation which aggregate many points feature to one point feature. In point transformer layer, the point number of outputs is same as the inputs.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, i'll go by your word for now :)

@lucidrains lucidrains merged commit b8fcbc2 into main Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants